Migrate IterableToContainInAnyOrderOnlyEntriesExpectationsSpec to kotlin-test - #2188
Conversation
|
|
||
| context("mismatches and additional entries") { | ||
| describe("mismatches and additional entries") { | ||
| it("1.1, $toBeGreaterThanFun(3.1), $toBeGreaterThanFun(4.1) -- $toBeGreaterThanFun(4.1) is wrong and 2.1, 3.1 and 4.1 are missing") { |
There was a problem hiding this comment.
@ShahriyarSheikh looks like this results in a file name which is too long for Microsoft (https://github.com/robstoll/atrium/actions/runs/32659214848/job/97251684965?pr=2188#step:5:454). I suggest we split
non_nullable_cases into multiple functions:
- empty_collection
- happy_cases
- error_case_additional_entries
- error_case_mismatches
- error_case_mismatches_and_additional_entries
- error_case_too_many_matchers
- report_options
similar for nullableCases, lets split it into:
- nullable_happy_cases
- error_case_additional_entries (with
it("null, $toEqualFun(1.1), $toEqualFun(3.1) -- second null was missing") {) - etc.
There was a problem hiding this comment.
@robstoll good catch. I will split the non-nullable and nullable cases into separate test factories as suggested to shorten the generated test names. I’ll push the update shortly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2188 +/- ##
============================================
+ Coverage 90.90% 91.28% +0.37%
Complexity 125 125
============================================
Files 469 469
Lines 4784 4784
Branches 242 242
============================================
+ Hits 4349 4367 +18
+ Misses 383 366 -17
+ Partials 52 51 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
robstoll
left a comment
robstoll
left a comment
There was a problem hiding this comment.
@ShahriyarSheikh now everything is green. Thanks for your first contribution to Atrium 🙂👍
How about another one?
2 participants
Closes #2024
Summary
IterableToContainInAnyOrderOnlyEntriesExpectationsSpecfrom Spek to kotlin-testExpectationFunctionBaseTestand test factoriesambiguityTestwith real subjects and valid expectationsTesting
:atrium-specs:compileKotlinJvm:atrium-api-fluent:jvmTest --tests "ch.tutteli.atrium.api.fluent.en_GB.IterableToContainInAnyOrderOnlyEntriesExpectationsTest":atrium-api-infix:jvmTest --tests "ch.tutteli.atrium.api.infix.en_GB.IterableToContainInAnyOrderOnlyEntriesExpectationsTest"I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.